feat: add logging when publisherId is missing in VTEXAdsProvider#631
feat: add logging when publisherId is missing in VTEXAdsProvider#631rogeralbinoi wants to merge 5 commits intomasterfrom
Conversation
rogeralbinoi
requested review from
RodrigoTadeuF,
gabpaladino and
vmourac-vtex
and removed request for
a team
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
amandascm
left a comment
amandascm
left a comment
There was a problem hiding this comment.
LGTM 👏🏼
(Se puder, adiciona aqui também as evidências que você testou e viu os logs chegarem)
|
After investigating a bit further, we identified that it won’t be possible to add these logs, because most stores without ADS would be triggered by the alerts. We have roughly 8k stores without ADS, which would result in a large number of false positives. |
2 participants
What problem is this solving?
This PR adds temporary logging functionality to track domains that don't have the
publisherIdconfiguration registered in the VTEXAdsProvider. This will help us quickly identify and fix domains missing this critical configuration.Currently, when
publisherIdis missing, the component silently returns the children without any tracking mechanism. This makes it difficult to identify which domains need the configuration to be set up.Note: This is a temporary solution for tracking purposes. Once we've identified and fixed all domains missing the configuration, this logging can be removed.
How to test it?
[Workspace](Link goes here!)
To test:
publisherIdconfigured in the store settings